Removing unused find-bugs code

13 files changed, 0 insertions, 32 deletions

diff --git a/ime/app/src/main/java/com/anysoftkeyboard/ime/AnySoftKeyboardPopText.java b/ime/app/src/main/java/com/anysoftkeyboard/ime/AnySoftKeyboardPopText.java
index 8f08fdd6b..567096a99 100644
--- a/ime/app/src/main/java/com/anysoftkeyboard/ime/AnySoftKeyboardPopText.java
+++ b/ime/app/src/main/java/com/anysoftkeyboard/ime/AnySoftKeyboardPopText.java
@@ -25,7 +25,6 @@ import com.anysoftkeyboard.keyboards.views.AnyKeyboardViewWithExtraDraw;
 import com.anysoftkeyboard.keyboards.views.extradraw.PopTextExtraDraw;
 import com.anysoftkeyboard.rx.GenericOnError;
 import com.menny.android.anysoftkeyboard.R;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 public abstract class AnySoftKeyboardPopText extends AnySoftKeyboardPowerSaving {
 
@@ -50,7 +49,6 @@ public abstract class AnySoftKeyboardPopText extends AnySoftKeyboardPowerSaving
                                 GenericOnError.onError("settings_key_pop_text_option")));
     }
 
-    @SuppressFBWarnings("SF_SWITCH_FALLTHROUGH")
     @SuppressWarnings("fallthrough")
     private void updatePopTextPrefs(String newValue) {
         mPopTextOnCorrection = false;
diff --git a/ime/app/src/main/java/com/anysoftkeyboard/keyboards/ExternalAnyKeyboard.java b/ime/app/src/main/java/com/anysoftkeyboard/keyboards/ExternalAnyKeyboard.java
index 65b2085d2..c30dc2806 100644
--- a/ime/app/src/main/java/com/anysoftkeyboard/keyboards/ExternalAnyKeyboard.java
+++ b/ime/app/src/main/java/com/anysoftkeyboard/keyboards/ExternalAnyKeyboard.java
@@ -34,7 +34,6 @@ import com.anysoftkeyboard.keyboards.AnyKeyboard.HardKeyboardTranslator;
 import com.anysoftkeyboard.utils.LocaleTools;
 import com.menny.android.anysoftkeyboard.AnyApplication;
 import com.menny.android.anysoftkeyboard.BuildConfig;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.text.ParseException;
 import java.util.Arrays;
@@ -418,7 +417,6 @@ public class ExternalAnyKeyboard extends AnyKeyboard implements HardKeyboardTran
     }
 
     @Override
-    @SuppressFBWarnings("EI_EXPOSE_REP")
     public char[] getSentenceSeparators() {
         return mSentenceSeparators;
     }
diff --git a/ime/app/src/main/java/com/anysoftkeyboard/keyboards/views/AnyKeyboardViewBase.java b/ime/app/src/main/java/com/anysoftkeyboard/keyboards/views/AnyKeyboardViewBase.java
index d71a4110e..64c121735 100644
--- a/ime/app/src/main/java/com/anysoftkeyboard/keyboards/views/AnyKeyboardViewBase.java
+++ b/ime/app/src/main/java/com/anysoftkeyboard/keyboards/views/AnyKeyboardViewBase.java
@@ -78,7 +78,6 @@ import com.anysoftkeyboard.utils.EmojiUtils;
 import com.menny.android.anysoftkeyboard.AnyApplication;
 import com.menny.android.anysoftkeyboard.BuildConfig;
 import com.menny.android.anysoftkeyboard.R;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import io.reactivex.Observable;
 import io.reactivex.disposables.CompositeDisposable;
 import io.reactivex.subjects.BehaviorSubject;
@@ -1941,7 +1940,6 @@ public class AnyKeyboardViewBase extends View implements InputViewBinder, Pointe
         return false;
     }
 
-    @SuppressFBWarnings("EI_EXPOSE_REP")
     public int[] getLocationInWindow() {
         getLocationInWindow(mThisWindowOffset);
         return mThisWindowOffset;
diff --git a/ime/app/src/main/java/com/anysoftkeyboard/keyboards/views/KeyDetector.java b/ime/app/src/main/java/com/anysoftkeyboard/keyboards/views/KeyDetector.java
index 4d31069d1..358522206 100644
--- a/ime/app/src/main/java/com/anysoftkeyboard/keyboards/views/KeyDetector.java
+++ b/ime/app/src/main/java/com/anysoftkeyboard/keyboards/views/KeyDetector.java
@@ -20,7 +20,6 @@ import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
 import com.anysoftkeyboard.keyboards.AnyKeyboard;
 import com.anysoftkeyboard.keyboards.Keyboard;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.Arrays;
 
 public abstract class KeyDetector {
@@ -83,7 +82,6 @@ public abstract class KeyDetector {
      *     #getKeyIndexAndNearbyCodes} method. All elements in the returned array are initialized by
      *     {@link AnyKeyboardViewBase#NOT_A_KEY} value.
      */
-    @SuppressFBWarnings("EI_EXPOSE_REP")
     int[] newCodeArray() {
         Arrays.fill(mNearByCodes, AnyKeyboardViewBase.NOT_A_KEY);
         return mNearByCodes;
diff --git a/ime/app/src/main/java/com/anysoftkeyboard/quicktextkeys/QuickTextKey.java b/ime/app/src/main/java/com/anysoftkeyboard/quicktextkeys/QuickTextKey.java
index 29e58d601..43eb2fc03 100644
--- a/ime/app/src/main/java/com/anysoftkeyboard/quicktextkeys/QuickTextKey.java
+++ b/ime/app/src/main/java/com/anysoftkeyboard/quicktextkeys/QuickTextKey.java
@@ -21,7 +21,6 @@ import android.content.res.Resources;
 import android.content.res.TypedArray;
 import android.support.annotation.Nullable;
 import com.anysoftkeyboard.addons.AddOnImpl;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.Arrays;
 import java.util.List;
 
@@ -35,15 +34,9 @@ public class QuickTextKey extends AddOnImpl {
 
     private CharSequence mKeyLabel;
 
-    @SuppressFBWarnings(
-            value = "URF_UNREAD_FIELD",
-            justification = "At some point, we might want to do that")
     @SuppressWarnings("UnusedVariable")
     private int mKeyIconResId;
 
-    @SuppressFBWarnings(
-            value = "URF_UNREAD_FIELD",
-            justification = "At some point, we might want to do that")
     @SuppressWarnings("UnusedVariable")
     private int mIconPreviewResId;
 
diff --git a/ime/app/src/main/java/com/anysoftkeyboard/ui/tutorials/VersionChangeLogs.java b/ime/app/src/main/java/com/anysoftkeyboard/ui/tutorials/VersionChangeLogs.java
index 1b9da0f59..07f04a1b4 100644
--- a/ime/app/src/main/java/com/anysoftkeyboard/ui/tutorials/VersionChangeLogs.java
+++ b/ime/app/src/main/java/com/anysoftkeyboard/ui/tutorials/VersionChangeLogs.java
@@ -2,7 +2,6 @@ package com.anysoftkeyboard.ui.tutorials;
 
 import android.net.Uri;
 import android.text.TextUtils;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Locale;
@@ -578,7 +577,6 @@ public class VersionChangeLogs {
         return log;
     }
 
-    @SuppressFBWarnings("URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
     public static class VersionChangeLog {
         public final String versionName;
         public final String[] changes;
diff --git a/ime/app/src/main/java/com/menny/android/anysoftkeyboard/AnyApplication.java b/ime/app/src/main/java/com/menny/android/anysoftkeyboard/AnyApplication.java
index 3119c7299..8e82dfcde 100644
--- a/ime/app/src/main/java/com/menny/android/anysoftkeyboard/AnyApplication.java
+++ b/ime/app/src/main/java/com/menny/android/anysoftkeyboard/AnyApplication.java
@@ -53,7 +53,6 @@ import com.anysoftkeyboard.quicktextkeys.QuickTextKeyFactory;
 import com.anysoftkeyboard.saywhat.PublicNotice;
 import com.anysoftkeyboard.theme.KeyboardThemeFactory;
 import com.anysoftkeyboard.ui.tutorials.TutorialsProvider;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import io.reactivex.Observable;
 import io.reactivex.disposables.CompositeDisposable;
 import io.reactivex.functions.Consumer;
@@ -134,7 +133,6 @@ public class AnyApplication extends Application {
                 filename);
     }
 
-    @SuppressFBWarnings("ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD")
     @Override
     public void onCreate() {
         super.onCreate();
diff --git a/ime/app/src/main/java/com/menny/android/anysoftkeyboard/ChewbaccaUncaughtExceptionHandler.java b/ime/app/src/main/java/com/menny/android/anysoftkeyboard/ChewbaccaUncaughtExceptionHandler.java
index c20b71021..f16c66b1a 100644
--- a/ime/app/src/main/java/com/menny/android/anysoftkeyboard/ChewbaccaUncaughtExceptionHandler.java
+++ b/ime/app/src/main/java/com/menny/android/anysoftkeyboard/ChewbaccaUncaughtExceptionHandler.java
@@ -31,7 +31,6 @@ import android.text.format.DateFormat;
 import com.anysoftkeyboard.base.utils.Logger;
 import com.anysoftkeyboard.ui.SendBugReportUiActivity;
 import com.anysoftkeyboard.ui.dev.DeveloperUtils;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import io.reactivex.functions.Consumer;
 import java.io.File;
 import java.lang.Thread.UncaughtExceptionHandler;
@@ -238,7 +237,6 @@ class ChewbaccaUncaughtExceptionHandler implements UncaughtExceptionHandler, Con
         }
     }
 
-    @SuppressFBWarnings("REC_CATCH_EXCEPTION")
     private String getMemory() {
         String mem =
                 "Total: "
diff --git a/ime/app/src/test/java/com/anysoftkeyboard/dictionaries/BTreeDictionaryTest.java b/ime/app/src/test/java/com/anysoftkeyboard/dictionaries/BTreeDictionaryTest.java
index ca9ab3ca5..120b4e99f 100644
--- a/ime/app/src/test/java/com/anysoftkeyboard/dictionaries/BTreeDictionaryTest.java
+++ b/ime/app/src/test/java/com/anysoftkeyboard/dictionaries/BTreeDictionaryTest.java
@@ -24,7 +24,6 @@ import static org.junit.Assert.assertTrue;
 
 import com.anysoftkeyboard.AnySoftKeyboardRobolectricTestRunner;
 import com.menny.android.anysoftkeyboard.R;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.ArrayList;
 import java.util.Random;
 import java.util.concurrent.atomic.AtomicInteger;
@@ -34,7 +33,6 @@ import org.junit.Test;
 import org.junit.runner.RunWith;
 
 @RunWith(AnySoftKeyboardRobolectricTestRunner.class)
-@SuppressFBWarnings("SIC_INNER_SHOULD_BE_STATIC_ANON")
 public class BTreeDictionaryTest {
 
     private TestableBTreeDictionary mDictionaryUnderTest;
diff --git a/ime/app/src/test/java/com/anysoftkeyboard/keyboards/views/preview/AboveKeyPositionCalculatorTest.java b/ime/app/src/test/java/com/anysoftkeyboard/keyboards/views/preview/AboveKeyPositionCalculatorTest.java
index a664aafb9..a045adc58 100644
--- a/ime/app/src/test/java/com/anysoftkeyboard/keyboards/views/preview/AboveKeyPositionCalculatorTest.java
+++ b/ime/app/src/test/java/com/anysoftkeyboard/keyboards/views/preview/AboveKeyPositionCalculatorTest.java
@@ -6,7 +6,6 @@ import android.graphics.drawable.Drawable;
 import android.view.View;
 import com.anysoftkeyboard.AnySoftKeyboardRobolectricTestRunner;
 import com.anysoftkeyboard.keyboards.Keyboard;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
@@ -16,7 +15,6 @@ import org.mockito.invocation.InvocationOnMock;
 import org.mockito.stubbing.Answer;
 
 @RunWith(AnySoftKeyboardRobolectricTestRunner.class)
-@SuppressFBWarnings("SIC_INNER_SHOULD_BE_STATIC_ANON")
 public class AboveKeyPositionCalculatorTest {
     private AboveKeyPositionCalculator mUnderTest;
     private Keyboard.Key mTestKey;
diff --git a/ime/base/build.gradle b/ime/base/build.gradle
index 6bc65120b..f36ff8675 100644
--- a/ime/base/build.gradle
+++ b/ime/base/build.gradle
@@ -6,8 +6,6 @@ dependencies {
     api 'com.getkeepsafe.relinker:relinker:1.3.1'
     api project(path: ':api')
     api "com.android.support:support-v4:$supportLibVersion"
-    //so I can use SuppressFBWarnings
-    api('com.google.code.findbugs:annotations:3.0.0')
 
     testImplementation project(":ime:base-test")
 }
diff --git a/ime/nextword/src/main/java/com/anysoftkeyboard/nextword/NextWordStatistics.java b/ime/nextword/src/main/java/com/anysoftkeyboard/nextword/NextWordStatistics.java
index 4e1bcee53..438e6ef3d 100644
--- a/ime/nextword/src/main/java/com/anysoftkeyboard/nextword/NextWordStatistics.java
+++ b/ime/nextword/src/main/java/com/anysoftkeyboard/nextword/NextWordStatistics.java
@@ -1,8 +1,5 @@
 package com.anysoftkeyboard.nextword;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
-
-@SuppressFBWarnings("URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
 public class NextWordStatistics {
     public final int firstWordCount;
     public final int secondWordCount;
diff --git a/ime/prefs/src/test/java/com/anysoftkeyboard/prefs/RxSharedPrefsTest.java b/ime/prefs/src/test/java/com/anysoftkeyboard/prefs/RxSharedPrefsTest.java
index b07d7a38a..4eedf3398 100644
--- a/ime/prefs/src/test/java/com/anysoftkeyboard/prefs/RxSharedPrefsTest.java
+++ b/ime/prefs/src/test/java/com/anysoftkeyboard/prefs/RxSharedPrefsTest.java
@@ -8,7 +8,6 @@ import android.preference.PreferenceManager;
 import com.anysoftkeyboard.AnySoftKeyboardRobolectricTestRunner;
 import com.anysoftkeyboard.test.SharedPrefsHelper;
 import com.f2prateek.rx.preferences2.Preference;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import io.reactivex.disposables.CompositeDisposable;
 import java.util.concurrent.atomic.AtomicReference;
 import org.junit.After;
@@ -18,7 +17,6 @@ import org.junit.Test;
 import org.junit.runner.RunWith;
 
 @RunWith(AnySoftKeyboardRobolectricTestRunner.class)
-@SuppressFBWarnings("DLS_DEAD_LOCAL_STORE")
 public class RxSharedPrefsTest {
 
     private CompositeDisposable mCompositeDisposable;