diff options
| author | Felix Hanley <felix@userspace.com.au> | 2017-11-30 00:48:08 +0000 |
|---|---|---|
| committer | Felix Hanley <felix@userspace.com.au> | 2017-11-30 00:48:08 +0000 |
| commit | e3cec0db84b6f7e85c84e63d96bc52bb5eaece9e (patch) | |
| tree | 1c25b52fd831b5271017f03aca3c807431de9c06 | |
| parent | 8bc03a9dbb89e1e0ca5e472a5e7dcc0734e663e5 (diff) | |
| download | logger-e3cec0db84b6f7e85c84e63d96bc52bb5eaece9e.tar.gz logger-e3cec0db84b6f7e85c84e63d96bc52bb5eaece9e.tar.bz2 | |
Update tests for trailing newline
| -rw-r--r-- | default.go | 3 | ||||
| -rw-r--r-- | logger_test.go | 8 | ||||
| -rw-r--r-- | outputs/keyvalue/keyvalue_test.go | 8 |
3 files changed, 10 insertions, 9 deletions
@@ -24,7 +24,6 @@ func (dw DefaultWriter) Write(w io.Writer, m Message) { } for _, f := range m.Fields { - io.WriteString(w, " ") - io.WriteString(w, ToString(f)) + io.WriteString(w, fmt.Sprintf(" %s", ToString(f))) } } diff --git a/logger_test.go b/logger_test.go index ec9b78c..d349801 100644 --- a/logger_test.go +++ b/logger_test.go @@ -13,20 +13,22 @@ func TestDefaultWriter(t *testing.T) { }{ { in: []interface{}{"one"}, - out: "[INFO ] testlog: one", + out: "[INFO ] testlog: one\n", }, { in: []interface{}{"one", "two", "2"}, - out: "[INFO ] testlog: one two 2", + out: "[INFO ] testlog: one two 2\n", }, { in: []interface{}{"one", "two", "2", "three", 3}, - out: "[INFO ] testlog: one two 2 three 3", + out: "[INFO ] testlog: one two 2 three 3\n", }, + /* TODO maps are not ordered { in: []interface{}{"one", map[string]string{"two": "2", "three": "3"}}, out: "[INFO ] testlog: one two 2 three 3", }, + */ } for _, tt := range tests { diff --git a/outputs/keyvalue/keyvalue_test.go b/outputs/keyvalue/keyvalue_test.go index 7abe81e..b45a5cd 100644 --- a/outputs/keyvalue/keyvalue_test.go +++ b/outputs/keyvalue/keyvalue_test.go @@ -14,19 +14,19 @@ func TestKeyValueWriter(t *testing.T) { }{ { in: []interface{}{"one"}, - out: "[INFO ] test: message=one", + out: "[INFO ] test: message=one\n", }, { in: []interface{}{"one", "two", "2"}, - out: "[INFO ] test: message=one two=2", + out: "[INFO ] test: message=one two=2\n", }, { in: []interface{}{"one", "two", "2", "three", 3}, - out: "[INFO ] test: message=one two=2 three=3", + out: "[INFO ] test: message=one two=2 three=3\n", }, { in: []interface{}{"one", "two", "2", "three", 3, "fo ur", "# 4"}, - out: "[INFO ] test: message=one two=2 three=3 \"fo ur\"=\"# 4\"", + out: "[INFO ] test: message=one two=2 three=3 \"fo ur\"=\"# 4\"\n", }, } |
