aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelix Hanley <felix@userspace.com.au>2017-11-30 00:48:08 +0000
committerFelix Hanley <felix@userspace.com.au>2017-11-30 00:48:08 +0000
commite3cec0db84b6f7e85c84e63d96bc52bb5eaece9e (patch)
tree1c25b52fd831b5271017f03aca3c807431de9c06
parent8bc03a9dbb89e1e0ca5e472a5e7dcc0734e663e5 (diff)
downloadlogger-e3cec0db84b6f7e85c84e63d96bc52bb5eaece9e.tar.gz
logger-e3cec0db84b6f7e85c84e63d96bc52bb5eaece9e.tar.bz2
Update tests for trailing newline
-rw-r--r--default.go3
-rw-r--r--logger_test.go8
-rw-r--r--outputs/keyvalue/keyvalue_test.go8
3 files changed, 10 insertions, 9 deletions
diff --git a/default.go b/default.go
index c87ff2d..1246153 100644
--- a/default.go
+++ b/default.go
@@ -24,7 +24,6 @@ func (dw DefaultWriter) Write(w io.Writer, m Message) {
}
for _, f := range m.Fields {
- io.WriteString(w, " ")
- io.WriteString(w, ToString(f))
+ io.WriteString(w, fmt.Sprintf(" %s", ToString(f)))
}
}
diff --git a/logger_test.go b/logger_test.go
index ec9b78c..d349801 100644
--- a/logger_test.go
+++ b/logger_test.go
@@ -13,20 +13,22 @@ func TestDefaultWriter(t *testing.T) {
}{
{
in: []interface{}{"one"},
- out: "[INFO ] testlog: one",
+ out: "[INFO ] testlog: one\n",
},
{
in: []interface{}{"one", "two", "2"},
- out: "[INFO ] testlog: one two 2",
+ out: "[INFO ] testlog: one two 2\n",
},
{
in: []interface{}{"one", "two", "2", "three", 3},
- out: "[INFO ] testlog: one two 2 three 3",
+ out: "[INFO ] testlog: one two 2 three 3\n",
},
+ /* TODO maps are not ordered
{
in: []interface{}{"one", map[string]string{"two": "2", "three": "3"}},
out: "[INFO ] testlog: one two 2 three 3",
},
+ */
}
for _, tt := range tests {
diff --git a/outputs/keyvalue/keyvalue_test.go b/outputs/keyvalue/keyvalue_test.go
index 7abe81e..b45a5cd 100644
--- a/outputs/keyvalue/keyvalue_test.go
+++ b/outputs/keyvalue/keyvalue_test.go
@@ -14,19 +14,19 @@ func TestKeyValueWriter(t *testing.T) {
}{
{
in: []interface{}{"one"},
- out: "[INFO ] test: message=one",
+ out: "[INFO ] test: message=one\n",
},
{
in: []interface{}{"one", "two", "2"},
- out: "[INFO ] test: message=one two=2",
+ out: "[INFO ] test: message=one two=2\n",
},
{
in: []interface{}{"one", "two", "2", "three", 3},
- out: "[INFO ] test: message=one two=2 three=3",
+ out: "[INFO ] test: message=one two=2 three=3\n",
},
{
in: []interface{}{"one", "two", "2", "three", 3, "fo ur", "# 4"},
- out: "[INFO ] test: message=one two=2 three=3 \"fo ur\"=\"# 4\"",
+ out: "[INFO ] test: message=one two=2 three=3 \"fo ur\"=\"# 4\"\n",
},
}